fix: convert invalid recipe variable name to raw content#3420
Merged
lifeizhou-ap merged 1 commit intomainfrom Jul 15, 2025
Merged
fix: convert invalid recipe variable name to raw content#3420lifeizhou-ap merged 1 commit intomainfrom
lifeizhou-ap merged 1 commit intomainfrom
Conversation
yingjiehe-xyz
approved these changes
Jul 15, 2025
| let mut vars_to_convert = Vec::new(); | ||
|
|
||
| for var in template_variables { | ||
| // Create individual environment for each validation |
Contributor
There was a problem hiding this comment.
Don't think we need this comment (code self-explains)
| .collect() | ||
| } | ||
|
|
||
| fn filter_complex_variables(template_variables: &[String]) -> Vec<String> { |
Contributor
There was a problem hiding this comment.
Can we add a little comment about what complex variables are? Is space before and after the name but not inbetween?
jsibbison-square
approved these changes
Jul 15, 2025
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 15, 2025
* main: fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) fix checkout for non mac builds (#3408) Docs: Voice dictation in Goose Desktop (#3376) docs: cli theme persistence (#3398) docs: goose mobile (#3403)
zanesq
added a commit
that referenced
this pull request
Jul 15, 2025
* 'main' of github.com:block/goose: fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) feat: Add AZURE_OPENAI_API_KEY as a visible config parameter (#3265) feat: stream LLM responses (#2677) # Conflicts: # crates/goose/src/session/storage.rs # ui/desktop/src/components/ChatView.tsx # ui/desktop/src/components/settings/extensions/subcomponents/ExtensionList.tsx
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 16, 2025
* main: (54 commits) UI update with sidebar and settings tabs (#3288) docs: add CLIStreamExtensionInstructions component (#3443) chore(release): release version 1.0.36 (#3436) [goose-llm] fix image content bug, add optional request_id field (#3439) fix: Set include_usage=true for OpenAI streaming (#3441) feat: `recipe list` (#2814) (#2815) docs: update github mcp config (#3433) feat: Implement streaming for OpenAI (#3413) fix: improve extension startup error messages with command details (#2694) [feat]: improve file search tools to add globsearch / grep tools (#3368) docs: typo in guide description (#3429) fix: use safe_truncate to truncate charactor (#3263) (#3264) fix: convert invalid recipe variable name to raw content (#3420) center goose mobile screenshot (#3418) docs: model context limit overrides (#3377) docs: Subagents (#3402) fix: avoid pass encoded empty string to goose run --recipe (#3361) ux: alphabetize extensions (#3416) fix: message concatenation in server session management (#3412) refactor: streamline memory directory management (#3345) ...
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
kwsantiago
pushed a commit
to kwsantiago/goose
that referenced
this pull request
Jul 19, 2025
Signed-off-by: Kyle Santiago <kyle@privkey.io>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Currently if user adds content
results/{{hf_model_org}__{hf_model_name}}/{model commit id}/{task name}.jsonin the recipe, it will fail when rendering the template.With this example, the user does not intend to introduce variables in the recipe file. Instead, they are the raw content.
What
Convert the string that seems like template variable to raw content
How
Note
With this implementation, user could add the template variables incorrectly and then it will be converted to raw content. This might happen.
However, when using running the recipe, we also validate the recipe with the template variable and parameters definition. In addition, when we run the recipe, the parameter values are also printed out which will be easy to debug.